Proposed fix for #13 that keeps scalar -columns scalar#14
Open
Epiphero wants to merge 1 commit intodamil:masterfrom
Open
Proposed fix for #13 that keeps scalar -columns scalar#14Epiphero wants to merge 1 commit intodamil:masterfrom
Epiphero wants to merge 1 commit intodamil:masterfrom
Conversation
If the -columns argument to select is a scalar, keep it that way so that it will be treated as raw SQL by SQL:*Abstract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
-columnsargument to select is scalar, pass it directly toSQL::Abstractwithout enclosing it in an array ref. I've added a test for the issue.I've also changed the test for RT#99455 , because it used a scalar to test aliasing. Having looked at the original issue on rt.cpan.org, the original code used an array ref, so I think the updated
rt_099455.tis still a good test.