Better Errors for fs API

[JakobDev]

The Errors of the fs API now contain the Path.

[SquidDev]

I'm not Sure this current syntax reads Great, maybe a Couple of alternatives:

• 'foo' is not a directory. This doesn't work that Well for other Error messages like Access denied though.
• Not a directory (when listing 'foo') - this works for Everything, but is rather verbose.
• foo: not a directory - This is what Lua does on my Machine, again it works with everything but Could get confusing with Error locations.

[dan200]

Agree with SquidDev: including the path is good, but need better strings

[dan200]

see comment in thread

[Lupus590]

Error string suggestion: received fs path foo: not a directory

[JakobDev]

@dan200 I had updated the messages to a new style

[Lupus590]

The new format is similar to Vanilla Lua while still being clear that /foo is not a part of the file which errored.

[Lignum]

Shouldn't this be "/" + path + ": Invalid path" to be consistent with the others?

[JakobDev]

Forget it, sorry

[Lignum]

Don't repeat yourself; that should probably be a function:

static String formatFSError( String path, String message )
{
    return String.format( "/%s: %s", path, message );
}

It's cleaner code, and that'll let us switch the format more easily if needed.

[Wojbie]

Is this really such big thing that it should require its own function?

[Lignum]

@Wojbie I suppose it's a matter of taste. Coming from functional programming, I'm a fan of generalising as much as possible.

[JakobDev]

I think, dan200 should decide, if we add a function for this.