RF move redirector testing into dandiapi testing?

[yarikoptic]

follow up (might be contingent on) to #976 , noticed that it is the only test aiming for redirector testing

$> git grep -2 mark.redirector
dandi/tests/test_utils.py-
dandi/tests/test_utils.py-
dandi/tests/test_utils.py:@pytest.mark.redirector
dandi/tests/test_utils.py-@using_docker
dandi/tests/test_utils.py-def test_server_info() -> None:

and it is not ran as part of the dandi/dandi-archive#1054 as it now should since it would be the one to provide server-info

[jwodder]

@yarikoptic The --dandi-api option used by the dandi-archive + dandi-cli integration tests only selects tests that use the Docker setup, and "adjusting" the test by just setting DANDI_REDIRECTOR_BASE in the integration tests will likely mess up various other tests. Should a separate test be added that does the same thing as this one, only focused on the Docker setup, or should the test be rewritten completely to only ever test against Docker? Or something else?

[jwodder]

@yarikoptic Ping; please respond to previous comment.

[yarikoptic]

Proceed with the minimal impact. I guess testing against dandi-archive docker setup (and thus "development" version in their CI iirc) would be sufficient.

[jwodder]

@yarikoptic What exactly are you asking for?

[yarikoptic]

since redirector service was deprecated and now dandi-archive is the one providing /server-info that test should be adjusted so that testing in dandi-archive

(git)lena:~/proj/dandi/dandi-archive[enh-release]git
$> git grep -3 pytest .github
.github/workflows/cli-integration.yml-
.github/workflows/cli-integration.yml-      - name: Run dandi-api tests in dandi-cli
.github/workflows/cli-integration.yml-        run: |
.github/workflows/cli-integration.yml:          python -m pytest -s -v --dandi-api \
.github/workflows/cli-integration.yml-            "$pythonLocation/lib/python${{ matrix.python }}/site-packages/dandi"
.github/workflows/cli-integration.yml-        env:
.github/workflows/cli-integration.yml-          DANDI_TESTS_PERSIST_DOCKER_COMPOSE: "1"

would test its new version/PR against it.

[jwodder]

@yarikoptic Are you saying that the Dockerized Dandi Archive now provides a /server-info endpoint? Because, after updating the test, I'm getting a 404.

This seems to imply that /server-info is a redirect to /api/info/ provided by netlify.

[yarikoptic]

you must be correct and I was wrong/mislead -- most likely indeed redirects since I see no mentioning of server-info in datalad-archive... filed dandi/dandi-archive#1108