Do not traverse .ome.zarr and .ngff folders while looking for BIDS datasets#1071
Do not traverse .ome.zarr and .ngff folders while looking for BIDS datasets#1071yarikoptic merged 4 commits intomasterfrom
Conversation
…tories e.g. to prevent searching for files under .zarr/ folders with thousands for files
…dataset_description.json Also added a log line so process is not just hanging while traversing but we know that it might be going through folders. Ideally we should add some debug messages in find_files I guess to alert user that we are not dead
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
+ Coverage 88.38% 88.40% +0.02%
==========================================
Files 72 72
Lines 9261 9272 +11
==========================================
+ Hits 8185 8197 +12
+ Misses 1076 1075 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
ok -- with this I fail (incorrect token) on our target use case within 3 seconds, so we manage to traverse enough fast enough, so effectively addresses the case. but may be we would tune bids detection more - see #1073 |
|
@yarikoptic - does the check still run when and secondarily, if we don't use that flag and do (and the one ngff file in MITU01 is being removed). |
the patch is only for
I don't think this patch should affect that behavior either, IMHO should not . If that behavior is wrong, we need a separate issue issue for that particular case - I am just trying to fix up #1069 here. |
…rr file Alerted to by @jwodder in #1071 (comment)
Fixes #1069
TODO