Factor out common fields in nwb2asset() and get_default_metadata()#1088
Factor out common fields in nwb2asset() and get_default_metadata()#1088yarikoptic merged 1 commit intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
+ Coverage 88.50% 88.52% +0.01%
==========================================
Files 73 73
Lines 9306 9295 -11
==========================================
- Hits 8236 8228 -8
+ Misses 1070 1067 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| def extract_digest( | ||
| metadata: dict, | ||
| ) -> Optional[Dict[models.DigestType, str]]: | ||
| def extract_digest(metadata: dict) -> Optional[Dict[models.DigestType, str]]: |
There was a problem hiding this comment.
I see no content difference -- why is it jumping like this then -- did we change blacking settings since last time this file was modified?
There was a problem hiding this comment.
No, I just noticed that the signature could fit on one line and felt compelled to fix it.
|
Thanks! I dislike functions with undocumented side-effects, but that is ok for now. Let's proceed. |
Closes #456.