Skip to content

Update client for change in Zarr entries API#1175

Merged
yarikoptic merged 4 commits intomasterfrom
archive-1394
Dec 19, 2022
Merged

Update client for change in Zarr entries API#1175
yarikoptic merged 4 commits intomasterfrom
archive-1394

Conversation

@jwodder
Copy link
Contributor

@jwodder jwodder commented Dec 15, 2022

@jwodder jwodder added minor Increment the minor version when merged zarr labels Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 89.15% // Head: 62.99% // Decreases project coverage by -26.16% ⚠️

Coverage data is based on head (c0f018d) compared to base (b704bca).
Patch coverage: 26.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1175       +/-   ##
===========================================
- Coverage   89.15%   62.99%   -26.17%     
===========================================
  Files          76       76               
  Lines        9525     9436       -89     
===========================================
- Hits         8492     5944     -2548     
- Misses       1033     3492     +2459     
Flag Coverage Δ
unittests 62.99% <26.47%> (-26.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/download.py 68.97% <0.00%> (-19.08%) ⬇️
dandi/files/zarr.py 39.52% <0.00%> (-48.85%) ⬇️
dandi/tests/test_dandiapi.py 25.11% <ø> (-74.89%) ⬇️
dandi/tests/test_files.py 66.25% <0.00%> (-33.75%) ⬇️
dandi/tests/test_upload.py 19.27% <0.00%> (-80.73%) ⬇️
dandi/dandiapi.py 52.54% <42.18%> (-35.74%) ⬇️
dandi/tests/test_delete.py 22.69% <0.00%> (-77.31%) ⬇️
dandi/upload.py 9.13% <0.00%> (-76.65%) ⬇️
dandi/tests/test_move.py 23.82% <0.00%> (-76.18%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jwodder jwodder marked this pull request as ready for review December 19, 2022 21:51
@jwodder
Copy link
Contributor Author

jwodder commented Dec 19, 2022

@yarikoptic The Dandi Archive PR has been merged, and @AlmightyYakob has requested that this be merged now as well. Should this have a "release" label?

@jjnesbitt
Copy link
Member

@yarikoptic The Dandi Archive PR has been merged, and @AlmightyYakob has requested that this be merged now as well. Should this have a "release" label?

For the record, I just assumed that this would need to be merged to maintain functionality against the zarr file listing endpoint, since the API is now deployed with the flat file listing.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Dec 19, 2022
@yarikoptic yarikoptic merged commit 54e2a12 into master Dec 19, 2022
@yarikoptic yarikoptic deleted the archive-1394 branch December 19, 2022 22:13
@github-actions
Copy link

🚀 PR was released in 0.48.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged release Create a release when this pr is merged released zarr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants