Skip to content

Remove deprecated use of Pydantic per Pydantic 2.11#1601

Merged
yarikoptic merged 1 commit intodandi:masterfrom
candleindark:pydantic-2_11
Apr 2, 2025
Merged

Remove deprecated use of Pydantic per Pydantic 2.11#1601
yarikoptic merged 1 commit intodandi:masterfrom
candleindark:pydantic-2_11

Conversation

@candleindark
Copy link
Member

@candleindark candleindark commented Apr 1, 2025

This PR closes #1600. See the individual commit for details.

This commit changes accessing of `model_fields` to
accesses from a Pydantic model class instead of an
instance of such a class. Accesses of
`model_fields` from a model class is deprecated
in Pydantic V2.11 to be removed in V3.0.
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.63%. Comparing base (386e50d) to head (50f01b0).
Report is 112 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1601      +/-   ##
==========================================
+ Coverage   88.58%   88.63%   +0.04%     
==========================================
  Files          78       78              
  Lines       10872    10872              
==========================================
+ Hits         9631     9636       +5     
+ Misses       1241     1236       -5     
Flag Coverage Δ
unittests 88.63% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@candleindark candleindark changed the title Add support of Pydantic 2.11 Remove deprecated use of Pydantic per Pydantic 2.11 Apr 1, 2025
@candleindark candleindark marked this pull request as ready for review April 1, 2025 05:03
@yarikoptic yarikoptic added the patch Increment the patch version when merged label Apr 1, 2025
@yarikoptic
Copy link
Member

description talks about multiple commits but there is only 1 . is that it ?

@candleindark
Copy link
Member Author

Yes, it turned out to be only one commit.

@yarikoptic yarikoptic merged commit b1815da into dandi:master Apr 2, 2025
63 of 67 checks passed
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

🚀 PR was released in 0.67.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated use of Pydantic

2 participants