Fixes #752 - Use non-bevelled borders for collapsed table cells. #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with solid style borders only. This should stop them being anti-aliased and problematic. Unfortunately some tests had to be re-proofed for this change. Additional test kindly provided by @gandboy91
Contributor
|
nice, I would guess it also fix #635 ? |
danfickle
added a commit
that referenced
this pull request
Sep 10, 2021
…isable bevels on borders. Doing so avoids ugly anti-aliasing effects, especially on tables. Property is: -fs-border-rendering: no-bevel and inherits so can be set at the table level to apply to all cells. This commit is a better alternative to the work in #755.
Owner
Author
|
Replaced with #761 which adds a property to explicitly disable bevelling, and thus avoids broken tests. |
Owner
Author
|
I'll remove the backing branch for this PR as #761 is essentially an extension of the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops them being anti-aliased which can look awful. I was able to piggy back off someone's work to remove bevelling on collapsed table cell borders from 14 years ago. It must have broke a long the way before automated testing was introduced.
Fixes #752, fixes #310.
Unfortunately this will break tests incorporating collapsed tables with table cell borders because of the tiny difference at the removed bevel. Any objections to merging?
P.S Release this week is planned.