Use ChurchQuery instead of proprietary filters #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-lerch
added
enhancement
There was a problem hiding this comment.
Pull request overview
This PR represents a major architectural refactoring of Mailist, transitioning from a proprietary filter system with ChurchTools sync to using ChurchQuery for dynamic person filtering. The changes remove approximately half of the backend code and introduce a modernized UI with PrimeVue components.
Key Changes
- Replaced PersonFilters with ChurchQuery-based filtering for distribution lists
- Removed ChurchTools synchronization service and related entity caching
- Added new Vue UI components for filter editing (PersonFilterEditor, AdvancedFilterEditor)
- Migrated from custom authentication to JWT-based authentication
Reviewed changes
Copilot reviewed 76 out of 78 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| webapp/src/services/churchquery.ts | New service implementing ChurchQuery filter parsing and conversion (contains critical bugs with zod usage) |
| webapp/src/views/*.vue | Updated views with PrimeVue components and new filter editing UI |
| server/Mailist/Controllers/DistributionListController.cs | Rewritten to use ChurchQuery API instead of database queries |
| server/Mailist/EmailRelay/*.cs | Updated to use ChurchQuery for recipient resolution |
| server/Mailist/Migrations/*.cs | Database migration removing PersonFilter tables and adding RecipientsQuery column |
| server/Mailist/ChurchTools/* | Removed sync service and entity classes |
| docs/*.md | Updated documentation to reflect JWT authentication and removed OAuth references |
Files not reviewed (2)
- server/Mailist/Migrations/20251205161928_ChurchQuery.Designer.cs: Language not supported
- webapp/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
server/Mailist/ChurchTools/ChurchToolsPermissionsHostedService.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a rewrite of large parts of Mailist. It removes half of the backend code including ChurchTools sync and PersonFilters. Instead, ChurchQuery is now being used. But this pull request also includes an all-new UI to edit filters.