feat(saves): show offline indicators in play section and saves tab (#221)#223
Merged
danielcopper merged 2 commits intomainfrom Apr 9, 2026
Merged
feat(saves): show offline indicators in play section and saves tab (#221)#223danielcopper merged 2 commits intomainfrom
danielcopper merged 2 commits intomainfrom
Conversation
) Add a conditional offline info item to the RomM play section (warning triangle + "RomM offline" label) and a red banner at the top of the saves tab explaining that slot switching is disabled while the server is unreachable. The saves tab subscribes to romm_connection_changed so the banner appears during the slots-loading state too.
Resolves SonarCloud typescript:S7764. Matches the pattern already used in RomMPlaySection for dispatching the same event.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
offline.slotsLoadingstate too, so the offline state is communicated immediately on tab open.romm_connection_changedevent (same pattern asCustomPlayButton), no new backend calls or API changes.Closes #221.
Test plan