Fix serialization of repeated fields with empty messages #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Hello there, |
Collaborator
|
Oops, I pressed ready for review not knowing what it does. If this is still WIP feel free to revert that. Otherwise, what's been committed so far is acceptable to me. |
nat-n
force-pushed
the
fix_empty_repeated
branch
3 times, most recently
from
31c63b3 to
022233f
Compare
Extend test config and utils to support exclusion of certain json samples from testing for symetry.
nat-n
force-pushed
the
fix_empty_repeated
branch
from
022233f to
188b186
Compare
Collaborator
Author
|
Rebased and finished refactoring some testing logic to allow json examples to be used for testing binary compatibility but skipped in the test for to_dict/from_dict symmetry. |
cetanu
previously approved these changes
Apr 6, 2021
cetanu
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #179
There's a failing test because the sample JSON for the binary compatibility test does not re-serialise to the same json (because it has deeply nested empty values). I need to amend the testing utils to allow for cases like this but would rather wait for #176 to be merged first to avoid conflicting refactors.