Include AsyncIterator import for both clients and servers #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazytype
commented
Aug 24, 2021
| @@ -1,5 +1,5 @@ | |||
| from abc import ABC | |||
| from collections import AsyncIterable | |||
| from collections.abc import AsyncIterable | |||
Contributor
Author
There was a problem hiding this comment.
This fixes the warning:
DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
TomaszMacudzinski-TomTom
previously approved these changes
Sep 20, 2021
roblabla
reviewed
Sep 29, 2021
Co-authored-by: Robin Lambertz <github@roblab.la>
|
This did indeed break in Python 3.10. Could this PR be merged and released please? |
kalzoo
approved these changes
Nov 3, 2021
| @@ -1,5 +1,5 @@ | |||
| from abc import ABC | |||
| from collections import AsyncIterable | |||
| from collections.abc import AsyncIterable | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #198
resolves #261
Any guidance on testing would be appreciated.