Refactor the way the 'watch' checkbox works. On the UI side this is i…#1
Merged
daniell merged 1 commit intoMay 21, 2015
Merged
Refactor the way the 'watch' checkbox works. On the UI side this is i…#1daniell merged 1 commit into
daniell merged 1 commit into
Conversation
…mplemented as a checkbox within a link. Clicking on it calls a view on the server, then reloads the existing page with the change applied. This makes it possible to have such action happen on clicking a tick box (rather than then having to press submit) without relying on javascript. So far this approach was only used for the 'watch' box. As we are introducing the same functionality for the 'done' checkbox, there could be a need for some refactoring. This is an experiment at finding a small refactoring, which formalizes this approach without trying to change the way it's implemented. As such it names such 'checkbox' action Single Action Views, and moves them in a file of their own, with their own base class. It may be that this is not the best approach, and either no refactoring, or rethinking the way this is implemented is a more adequate course of action.
daniell
added a commit
that referenced
this pull request
May 21, 2015
Refactor the way the 'watch' checkbox works. On the UI side this is i…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mplemented as a checkbox within a link. Clicking on it calls a view on the server, then reloads the existing page with the change applied. This makes it possible to have such action happen on clicking a tick box (rather than then having to press submit) without relying on javascript. So far this approach was only used for the 'watch' box. As we are introducing the same functionality for the 'done' checkbox, there could be a need for some refactoring. This is an experiment at finding a small refactoring, which formalizes this approach without trying to change the way it's implemented. As such it names such 'checkbox' action Single Action Views, and moves them in a file of their own, with their own base class. It may be that this is not the best approach, and either no refactoring, or rethinking the way this is implemented is a more adequate course of action.