selfcheck.yml: added callgrind step for basic (core) performance tracking
#4171
Conversation
|
Okay - the amount it takes to finish is actually acceptable (a bit over 20 minutes). Using clang should should make things even better. But using the current code base for makes no sense since the code we scan would change with every commit. So it needs to be a fixed corpus - like a release package of our code. |
firewave
force-pushed
the
selfcheck-callgrind
branch
2 times, most recently
from
21e2467 to
f97165b
Compare
|
With Clang it's less than 20 minutes. We could make it even faster by introduced a hack that we actually only perform the |
firewave
force-pushed
the
selfcheck-callgrind
branch
from
408b2ed to
fa78b64
Compare
* Optimization: Use Token::eIncDecOp instead of expensive Token::Match calls Merged from LCppC. * Small Optimizations: - Moved a std::set that is only need during initialization of SymbolDatabase to function scope - Use std::vector instead of std::list Merged from LCppC. * Optimization: Refactorized various Token::Match calls and surrounding conditions Merged from LCppC. * Refactorization: Cleanup usage of std::multimap Merged from LCppC.
firewave
force-pushed
the
selfcheck-callgrind
branch
from
fa78b64 to
c871d31
Compare
firewave
force-pushed
the
selfcheck-callgrind
branch
from
c871d31 to
0fcce2b
Compare
|
I think this job also makes sense without have the baseline comparison so we simply collect the performance metric so we can check which commit might have affected the performance in retrospect. The build takes about 14 minutes which is among the slowest in our CI but still a reasonable amount of time. If we are able to optimize a few things that will obviously be faster. Maybe there's also a way to tune this a bit. |
|
The main offender is https://trac.cppcheck.net/ticket/10663 which takes up almost 17% of the whole Ir. |
firewave
force-pushed
the
selfcheck-callgrind
branch
6 times, most recently
from
3a293d1 to
31a5fcf
Compare
firewave
force-pushed
the
selfcheck-callgrind
branch
from
5f73979 to
51788cb
Compare
|
This is ready for review now. The time it takes (~15 minutes) is reasonable and it will help to track the (core) performance which should only increase. It currently sits at |
firewave
force-pushed
the
selfcheck-callgrind
branch
from
51788cb to
101e150
Compare
firewave
changed the title
callgrind step for basic (core) performance tracking
2 participants
Using the
unusedFunctionself-check for profiling gives us a very basic case which involves the core functionality without the valueflow or most of the checks which should be a pretty good canary for speed improvements/regressions. Although the Ir does not translate directly into actual real time speed it would affects other jobs like the sanitized builds and would give an indication if it has any impact at all.