Patch from the conan center index recipe #4430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The changes look fine but somewhat arbitrary since the version-less Python shebang and FYI #3812 has the shebang changes as a whole but unfortunately it appears it was abandoned by the author. |
Contributor
Author
|
I revert the python version related commit. |
MartinDelille
force-pushed
the
cppcheck-cci29-patch
branch
from
bdc60dc to
6caaf39
Compare
Contributor
Author
|
I just rebase this PR against the main branch. |
Collaborator
|
Thanks, but you still didn't explain what problem this is fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are two patch that lives in the conan center index recipe.
Tell me if it is relevant of if it need some further improvements.