Skip to content

refs #10663 - only match start pattern in Library::detectContainerInternal() if necessary #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orbitcowboy merged 1 commit into from
Sep 23, 2022
Merged

refs #10663 - only match start pattern in Library::detectContainerInternal() if necessary #4499

orbitcowboy merged 1 commit into from
Sep 23, 2022

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Sep 23, 2022 •
edited
Loading

This gets rid of about half the Token::Match() calls when scanning mame_regtest (when re-enabling the Library calls in parsedecl() for C code). Better performance numbers soon.

@firewave
Copy link
Collaborator Author

firewave commented Sep 23, 2022

Using with the unusedFunction selfcheck with clang-14 from #2944:
84,868,419,217 -> 81,575,186,178

@orbitcowboy orbitcowboy merged commit e8b9cd6 into danmar:main Sep 23, 2022
@firewave firewave deleted the detectcontainer branch September 23, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @orbitcowboy