-
Notifications
You must be signed in to change notification settings - Fork 1.5k
installer: added missing library configurations and removed unneeded Qt DLLs / refs #10771 - added initial portable package #4669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I removed those DLLs and the GUI application was running fine. There's several other Qt DLLs which exist in the deployment folder but are not added into the installer and the application still runs fine. If the "portable" package is complete the "deploy" upload should only be performed in case the build fails for debugging purposes. A ticket about adding a portable package can be found at https://trac.cppcheck.net/ticket/10771. I will add updating of the filelists in the project files to |
win_installer/cppcheck.wxs
Outdated
| <File Id='boost.cfg' Name='boost.cfg' Source='$(var.CfgsDir)\boost.cfg' /> | ||
| <File Id='bsd.cfg' Name='bsd.cfg' Source='$(var.CfgsDir)\bsd.cfg' /> | ||
| <File Id='cairo.cfg' Name='cairo.cfg' Source='$(var.CfgsDir)\cairo.cfg' /> | ||
| <File Id='cppcheck-lib.cfg' Name='cppcheck-lib.cfg' Source='$(var.CfgsDir)\cppcheck-lib.cfg' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cppcheck users likely do not need this cppcheck-lib.cfg file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's possibly true for most of the files. 😁
Since we offer an API (and the accompanied cppcheck-core.dll) I think it makes sense to include this. I also assume the Linux packages do not omit this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this cppcheck-lib.cfg is only intended for our self check. I do not believe any users use cppcheck-core.dll in their software.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we offer an API
I do not know that we offer an API so the cppcheck-core.dll can be used. In theory you can copy the headers from our lib folder.. however those are changed every single version they are highly unstable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is included in the linux packages since make install copies all of them unconditionally: https://fedora.pkgs.org/38/fedora-aarch64/cppcheck-2.9-4.fc38.aarch64.rpm.html.
We need tests for the built packages in the CI which checks against a filelist for missing/unexpected files.
6d01986 to
bd4331a
Compare
73c3d29 to
1e5b61a
Compare
|
The following files in the |
|
The configuration list should also be generated/updated via |
|
|
Here's a link to successful build with the changes: https://github.com/danmar/cppcheck/actions/runs/6456891564/job/17527274412?pr=4669. |
No description provided.