Skip to content

Conversation

@firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Dec 30, 2022

I removed those DLLs and the GUI application was running fine. There's several other Qt DLLs which exist in the deployment folder but are not added into the installer and the application still runs fine.

If the "portable" package is complete the "deploy" upload should only be performed in case the build fails for debugging purposes. A ticket about adding a portable package can be found at https://trac.cppcheck.net/ticket/10771.

I will add updating of the filelists in the project files to dmake with a later PR.

<File Id='boost.cfg' Name='boost.cfg' Source='$(var.CfgsDir)\boost.cfg' />
<File Id='bsd.cfg' Name='bsd.cfg' Source='$(var.CfgsDir)\bsd.cfg' />
<File Id='cairo.cfg' Name='cairo.cfg' Source='$(var.CfgsDir)\cairo.cfg' />
<File Id='cppcheck-lib.cfg' Name='cppcheck-lib.cfg' Source='$(var.CfgsDir)\cppcheck-lib.cfg' />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cppcheck users likely do not need this cppcheck-lib.cfg file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's possibly true for most of the files. 😁

Since we offer an API (and the accompanied cppcheck-core.dll) I think it makes sense to include this. I also assume the Linux packages do not omit this.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this cppcheck-lib.cfg is only intended for our self check. I do not believe any users use cppcheck-core.dll in their software.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we offer an API

I do not know that we offer an API so the cppcheck-core.dll can be used. In theory you can copy the headers from our lib folder.. however those are changed every single version they are highly unstable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is included in the linux packages since make install copies all of them unconditionally: https://fedora.pkgs.org/38/fedora-aarch64/cppcheck-2.9-4.fc38.aarch64.rpm.html.

We need tests for the built packages in the CI which checks against a filelist for missing/unexpected files.

@firewave firewave force-pushed the install branch 3 times, most recently from 6d01986 to bd4331a Compare January 12, 2023 15:48
@firewave firewave force-pushed the install branch 3 times, most recently from 73c3d29 to 1e5b61a Compare February 25, 2023 17:45
@firewave
Copy link
Collaborator Author

firewave commented Feb 25, 2023

The following files in the addons folder are not included in the installer though it seems they should be (they most likely are on Linux):

cppcheck.py
cppcheckdata.doxyfile
misra.exe
naming.json
README.md
runaddon.py

@firewave firewave changed the title installer: added missing library configurations and removed unneeded Qt DLLs / also started portable package installer: added missing library configurations and removed unneeded Qt DLLs / refs #10771 - added initial portable package Feb 25, 2023
@firewave
Copy link
Collaborator Author

The configuration list should also be generated/updated via dmake. Something for the future.

@firewave
Copy link
Collaborator Author

firewave commented Aug 8, 2023

The following files in the addons folder are not included in the installer though it seems they should be (they most likely are on Linux):

make install only copies the *.py files so we should also include all of those on Windows. We do omit the *.json ones on Linux. CMake is doing something different - but that is already tracked in https://trac.cppcheck.net/ticket/8659. I will work on that in a separate PR.

@firewave
Copy link
Collaborator Author

firewave commented Oct 9, 2023

Here's a link to successful build with the changes: https://github.com/danmar/cppcheck/actions/runs/6456891564/job/17527274412?pr=4669.

@firewave firewave marked this pull request as ready for review October 9, 2023 14:15
@danmar danmar merged commit 784b526 into danmar:main Oct 11, 2023
@firewave firewave deleted the install branch November 27, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants