Skip to content

Colors: Do not output colors to a file #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danmar wants to merge 1 commit into from
Closed

Colors: Do not output colors to a file #4941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/color.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#endif
#include <cstddef>
#include <sstream> // IWYU pragma: keep
#include <iostream>

bool gDisableColors = false;

Expand All @@ -32,9 +33,16 @@ std::ostream& operator<<(std::ostream& os, const Color& /*c*/)
#else
std::ostream& operator<<(std::ostream & os, const Color& c)
{
// TODO: handle piping into file as well as other pipes like stderr
static const bool s_is_tty = isatty(STDOUT_FILENO);
if (!gDisableColors && s_is_tty)
static const bool isatty_stdout = isatty(STDOUT_FILENO);
static const bool isatty_stderr = isatty(STDERR_FILENO);
bool stream_is_tty;
if (&os == &std::cout)
stream_is_tty = isatty_stdout;
else if (&os == &std::cerr)
stream_is_tty = isatty_stderr;
else
stream_is_tty = (isatty_stdout && isatty_stderr);
if (!gDisableColors && stream_is_tty)
return os << "\033[" << static_cast<std::size_t>(c) << "m";
#endif
return os;
Expand Down