Check if --cppcheck-build-dir exists #5254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samopolacek
force-pushed
the
build_dir_existence
branch
from
6f2d157 to
ce881fe
Compare
Collaborator
|
On which platform does this happen? It works fine on Windows. |
Contributor
Author
|
I am running cppcheck on Debian 12. |
Collaborator
|
Upon further review, the directory has to be created beforehand on Windows as well. |
Collaborator
|
Please add a Also this should be implemented via a function in the |
Contributor
Author
|
samopolacek
force-pushed
the
build_dir_existence
branch
from
6765276 to
50d1c87
Compare
samopolacek
force-pushed
the
build_dir_existence
branch
from
efa8e0f to
492791c
Compare
Contributor
Author
@firewave , done from my side. Not sure what to do with the failing checks. I've already tried to rerun them, but they again failed. |
firewave
requested changes
Aug 1, 2023
firewave
approved these changes
Aug 1, 2023
firewave
reviewed
Aug 1, 2023
Collaborator
|
Turns out we already had the functionality implemented in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cppcheck does not report that cppcheck build dir does not exist and also does not report any write issues to the non-existent directory.
This means that cppcheck build dir is actually not used.
We should either create the directory or fail.