Skip to content

CppCheckExecutor: extracted logging instance related code into separate implementation class #5658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danmar merged 4 commits into from
Nov 16, 2023
Merged

CppCheckExecutor: extracted logging instance related code into separate implementation class #5658

danmar merged 4 commits into from
Nov 16, 2023

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Nov 14, 2023

No description provided.

@firewave firewave marked this pull request as ready for review November 14, 2023 11:33
@firewave
Copy link
Collaborator Author

firewave commented Nov 14, 2023

StdLogger still needs to be a member as check_internal() is not called directly. #5581 will slightly improve the situation but possibly not fully resolve it.

@danmar danmar merged commit 8b69cca into danmar:main Nov 16, 2023
@firewave firewave deleted the stdlogger branch November 16, 2023 09:39
@firewave firewave mentioned this pull request Sep 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @danmar