Skip to content

include GUI test sources in selfchecks #5687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
firewave wants to merge 5 commits into
base: main
Choose a base branch
from
Open

include GUI test sources in selfchecks #5687

firewave wants to merge 5 commits into from

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Nov 20, 2023

No description provided.

@firewave firewave changed the title removed unnecessary file pattern for GUI sources in selfcheck - GUI tests are now included include GUI test sources in selfcheck Nov 20, 2023
@firewave

This comment was marked as resolved.

Sign in to view
@firewave firewave marked this pull request as ready for review December 1, 2023 15:07
@firewave
Copy link
Collaborator Author

firewave commented Dec 1, 2023 •
edited
Loading

I added those as there's a passedByValue false negative in testcppchecklibrary. Also more dogfooding is always good.

I did suppress the naming-privateMemberVariable warnings since they would have caused almost all lines in the source to be changed.

The uninitMemberVar are not of interest since the classes are simply mocked.

danmar
danmar previously approved these changes Dec 1, 2023
View reviewed changes
@firewave firewave marked this pull request as draft December 4, 2023 16:30
firewave
firewave commented Mar 8, 2024
View reviewed changes
gui/test/projectfile/testprojectfile.cpp
#include "addoninfo.h"
#include "importproject.h"
// cppcheck-suppress-begin uninitMemberVar
#include "platform.h"
Copy link
Collaborator Author

@firewave firewave Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to suppress all the warnings from an include. I would expect this to work but it doesn't as it was probably not intended to be used that way. I will file a ticket about it.

Copy link
Collaborator Author

@firewave firewave Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed https://trac.cppcheck.net/ticket/14219 about being able to suppress the uninitMemberVar warnings per implementation

@firewave firewave mentioned this pull request Sep 8, 2025
Merged
@firewave firewave force-pushed the selfcheck-gui branch 5 times, most recently from 13d7da2 to 3c8cfd2 Compare October 22, 2025 20:40
@firewave firewave changed the title include GUI test sources in selfcheck include GUI test sources in selfchecks Nov 12, 2025
@firewave firewave marked this pull request as ready for review November 12, 2025 12:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmar danmar danmar left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@firewave @danmar