fixed #12227 - properly load addons from cppcheck.cfg in GUI
#5716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Requires #5710 to be merged first. |
Collaborator
Author
|
It would be better if the loading code were not duplicated and shared between the CLI and GUI code instead. One of the main issues is that we would lose the translated message. |
Collaborator
Author
|
@danmar Could you verify that this fixes your problem? Just to make sure I didn't make a mistake or there's not some hidden different issue. |
firewave
force-pushed
the
loadcfg-gui
branch
2 times, most recently
from
4e104cc to
03b4a3b
Compare
Owner
|
@firewave it solves the issue for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI was asserting when addons were specified in the
cppcheck.cfgsince we did not generate the info for them.