TestAstUtils: fixed consistency of language being used in isSameExpressionTest / added a few language checks
#5728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
astutils-test
branch
from
7c667bb to
0aa826f
Compare
Collaborator
Author
|
Extracted from #5725. Still needs to actual fixes/improvements done. Could need some help with the failures though as I don't really understand what it tests. |
firewave
force-pushed
the
astutils-test
branch
from
0aa826f to
759080b
Compare
Collaborator
Author
|
There's lots of more inconsistencies in these tests. All of these need to be tested with C and C++ tokenizing. But I have no idea how to do this without duplicating most of the code. It is not ass simple as the executor tests which can simply get a global boolean passed in. e.g. the |
firewave
force-pushed
the
astutils-test
branch
2 times, most recently
from
12c4f60 to
2173eb4
Compare
firewave
force-pushed
the
astutils-test
branch
2 times, most recently
from
6ec5ac1 to
60fb50b
Compare
firewave
force-pushed
the
astutils-test
branch
from
60fb50b to
a9ff4b4
Compare
Collaborator
Author
|
The changes in the tests are expected. In case of C++ |
firewave
changed the title
firewave
changed the title
isSameExpressionTest
firewave
changed the title
isSameExpressionTestisSameExpressionTest / added a few language checks
…nTest()` asserts / added some TODOs about missing test coverage
Co-authored-by: chrchr-github <78114321+chrchr-github@users.noreply.github.com>
firewave
force-pushed
the
astutils-test
branch
from
a9ff4b4 to
41c106f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the
isSameExpression()test we were tokenizing the code as C++ but were treating it as C later on.