Skip to content

Conversation

@firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Aug 10, 2024

Requires https://trac.cppcheck.net/ticket/12066 to be addressed first so we can put a version on the removal.

Parts of this will be extracted and put into separate PRs.

I also needed a base without the Qt5 code in to look into include-what-you-use issues/improvements for Qt.

@firewave
Copy link
Collaborator Author

Oh puppytails ... Ubuntu 20.04 has no Qt6 packages ...

readme.txt Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not kept in sync with the Markdown version and I think we should remove it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not kept in sync with the english version and I think we should remove it. See also https://trac.cppcheck.net/ticket/11979.

@firewave
Copy link
Collaborator Author

I think we can at least drop qmake support as CMake also supports Qt5.

@firewave firewave force-pushed the qt5-remove branch 2 times, most recently from c6718aa to 79e4438 Compare August 30, 2024 19:03
@firewave firewave force-pushed the qt5-remove branch 3 times, most recently from 701d87a to c23b5a8 Compare October 10, 2024 10:13
@firewave firewave force-pushed the qt5-remove branch 2 times, most recently from b63737d to de7c526 Compare October 28, 2024 10:15
@firewave firewave changed the title removed qmake and Qt5 support fixed #13133 - removed Qt5 support Oct 28, 2024
@firewave firewave force-pushed the qt5-remove branch 4 times, most recently from 284fa0a to 3db0642 Compare October 28, 2024 10:21
@firewave
Copy link
Collaborator Author

firewave commented Oct 28, 2024

Oh puppytails ... Ubuntu 20.04 has no Qt6 packages ...

That goes EOS in April 2025. So I would consider that acceptable.

@firewave firewave changed the title fixed #13133 - removed Qt5 support fixed #13133 - removed deprecated Qt5 support Oct 28, 2024
@firewave firewave force-pushed the qt5-remove branch 3 times, most recently from bc93fa2 to 113de4d Compare October 28, 2024 21:36
@firewave
Copy link
Collaborator Author

firewave commented Apr 9, 2025

Oh puppytails ... Ubuntu 20.04 has no Qt6 packages ...

That goes EOS in April 2025. So I would consider that acceptable.

And it is also gone from GitHub runners soon so that issue resolved itself.

@firewave
Copy link
Collaborator Author

firewave commented Aug 4, 2025

2.18.0 has been released so it is time to merged this.

Successful conditional builds with changes applied:
https://github.com/danmar/cppcheck/actions/runs/16721006441
https://github.com/danmar/cppcheck/actions/runs/16721006425

@firewave firewave marked this pull request as ready for review August 4, 2025 11:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave firewave merged commit 2e9b67c into danmar:main Aug 4, 2025
83 of 84 checks passed
@firewave firewave deleted the qt5-remove branch August 4, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants