-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fixed #13133 - removed deprecated Qt5 support #6678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Requires https://trac.cppcheck.net/ticket/12066 to be addressed first so we can put a version on the removal. Parts of this will be extracted and put into separate PRs. I also needed a base without the Qt5 code in to look into include-what-you-use issues/improvements for Qt. |
|
Oh puppytails ... Ubuntu 20.04 has no Qt6 packages ... |
readme.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not kept in sync with the Markdown version and I think we should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not kept in sync with the english version and I think we should remove it. See also https://trac.cppcheck.net/ticket/11979.
|
I think we can at least drop qmake support as CMake also supports Qt5. |
c6718aa to
79e4438
Compare
79e4438 to
2279a16
Compare
701d87a to
c23b5a8
Compare
b63737d to
de7c526
Compare
284fa0a to
3db0642
Compare
That goes EOS in April 2025. So I would consider that acceptable. |
bc93fa2 to
113de4d
Compare
And it is also gone from GitHub runners soon so that issue resolved itself. |
|
2.18.0 has been released so it is time to merged this. Successful conditional builds with changes applied: |
|
danmar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm



No description provided.