-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fixed #8659 - aligned contents of all install packages #6906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It is impressive how often things coincide... |
cf667ed to
5a35c65
Compare
|
@danmar What is the point of compiling It is included in the portable package but I guess that was not intentional. But that might not even work - see below. But including this causes the installer to blow up in side because the binary requires the Python libraries to be included as well. And I am not sure if that affects something regarding licensing (beside adding the Python license). |
587abfb to
3276893
Compare
5b40740 to
dedd0fc
Compare
19b31ee to
3e5f7ca
Compare
I made a "half hearted" attempt to distribute a misra addon that does not require python. We had a premium customer that didn't want to install python. I feel uncomfortable about distributing the compiled misra addon I see it as untested. If a customer really wants it and understands that I didn't test it properly but still wants to use it well I can let the customer test this. I think that for 99% of the customers it is OK to install python. If we remove the extra code from release-windows.yml that is fine for me.. but it would be nice if I had some way to build the compiled misra addon in some github action somewhere. |
I still included it in the portable package so it can be tested. |
|
The commit in cli/CMakeLists.txt breaks some builds. See for example https://github.com/OSGeo/gdal/actions/runs/12298084801/job/34320720920 : with the cppcheck build being done at https://github.com/OSGeo/gdal/blob/master/.github/workflows/code_checks.yml#L68 |
|
I had a feeling I still wanted to do something in this PR - add tests for the install to the CI. I can reproduce it locally and I am on it. |
|
I have a fix - PR will go up in a few minutes. |
|
See #7100. |
No description provided.