-
Notifications
You must be signed in to change notification settings - Fork 1.5k
removed unreachable debug-only type validation #7259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The functionality got lost when |
|
@chrchr-github @danmar is there still needed? "type validation" also seems misleading but I could not think of anything better. |
I don't know anything about it, but don't see a reason to keep this. |
|
I wrote that code 14 years ago and stopped contributing 7 years ago. It was needed back then but I have no idea if it's needed now. Does it still generate warnings in daca? |
Thanks for replying.
No, and it hasn't for a while. I also have not seen any reference to this since I started contributing again - that is why I am asking. Looks like we can just drop it then. |
bfc0069 to
091c6c8
Compare
091c6c8 to
e5f7f76
Compare
|
Since it has not has not been reachable for a while (the call was removed in d204c5f) and there was not much feedback I decided to remove it. |
No description provided.