Skip to content

Conversation

@firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

The functionality got lost when simplifyTokens2() was removed. It is possible this is no longer needed at all and can be removed instead.

@firewave firewave changed the title re-added type debug validation after simplification re-enabled debug-only type validation after simplification Jan 26, 2025
@firewave
Copy link
Collaborator Author

firewave commented Feb 6, 2025

@chrchr-github @danmar is there still needed?

"type validation" also seems misleading but I could not think of anything better.

@chrchr-github
Copy link
Collaborator

@chrchr-github @danmar is there still needed?

I don't know anything about it, but don't see a reason to keep this.

@firewave
Copy link
Collaborator Author

@danmar @IOBYTE do we still need this?

The warnings in question were added in f96a88e and 989235b.

@IOBYTE
Copy link
Contributor

IOBYTE commented Mar 15, 2025

I wrote that code 14 years ago and stopped contributing 7 years ago. It was needed back then but I have no idea if it's needed now. Does it still generate warnings in daca?

@firewave
Copy link
Collaborator Author

I wrote that code 14 years ago and stopped contributing 7 years ago.

Thanks for replying.

It was needed back then but I have no idea if it's needed now. Does it still generate warnings in daca?

No, and it hasn't for a while. I also have not seen any reference to this since I started contributing again - that is why I am asking. Looks like we can just drop it then.

@firewave firewave changed the title re-enabled debug-only type validation after simplification removed unreachable debug-only type validation after simplification Apr 24, 2025
@firewave firewave changed the title removed unreachable debug-only type validation after simplification removed unreachable debug-only type validation Apr 24, 2025
@firewave firewave marked this pull request as ready for review April 24, 2025 12:09
@firewave
Copy link
Collaborator Author

Since it has not has not been reachable for a while (the call was removed in d204c5f) and there was not much feedback I decided to remove it.

@firewave firewave merged commit e478486 into danmar:main May 6, 2025
53 of 54 checks passed
@firewave firewave deleted the validate-types branch May 6, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants