testrunner: start adding IDs and columns to error messages #7343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Requires #4377 and #7342 to be merged first. This will help with identifying missing test coverage. Those should be collected below https://trac.cppcheck.net/ticket/12232. It will also make clearer what is being tested. And would allow to re-group/limit of of the tests (in case someone really got absolutely nothing else to do). |
This comment was marked as outdated.
This comment was marked as outdated.
firewave
changed the title
firewave
force-pushed
the
unique-id
branch
3 times, most recently
from
d314bac to
cc587b1
Compare
firewave
force-pushed
the
unique-id
branch
2 times, most recently
from
89cf50d to
2bceaa8
Compare
firewave
commented
Mar 19, 2025
| " { }\n" | ||
| "}"); | ||
| ASSERT_EQUALS("[test.cpp:1]: (style) The function 'f1' is never used.\n", errout_str()); | ||
| ASSERT_EQUALS("[test.cpp:1:0]: (style) The function 'f1' is never used. [unusedFunction]\n", errout_str()); |
Collaborator
Author
There was a problem hiding this comment.
These should probably have a proper column.
Collaborator
Author
There was a problem hiding this comment.
I filed https://trac.cppcheck.net/ticket/13762 about this.
firewave
force-pushed
the
unique-id
branch
4 times, most recently
from
f8cc900 to
1308a55
Compare
danmar
reviewed
Apr 5, 2025
danmar
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.