Skip to content

Conversation

@ludviggunne
Copy link
Collaborator

@ludviggunne ludviggunne commented May 25, 2025

No description provided.

@danmar
Copy link
Owner

danmar commented May 25, 2025

"params": { "comments": 42, "statements": 62 }

let's assume for now that there will only be a "value": 123
we can report comments and statements as 2 separate metrics.

@ludviggunne ludviggunne force-pushed the metrics-xml branch 6 times, most recently from 3908d27 to 6503074 Compare May 29, 2025 09:17
@ludviggunne ludviggunne force-pushed the metrics-xml branch 5 times, most recently from 9c9b519 to 6d29281 Compare May 30, 2025 12:45
@ludviggunne ludviggunne marked this pull request as ready for review May 31, 2025 17:49
@danmar danmar merged commit 51f6d91 into danmar:main Jun 2, 2025
53 checks passed
@ludviggunne ludviggunne deleted the metrics-xml branch June 2, 2025 10:04
@firewave
Copy link
Collaborator

firewave commented Jun 2, 2025

The *.ts files should have been omitted from this.

And the newly added Python tests fail with #7079 applied. I have not looked into it as there is still a dozen other issues.

@ludviggunne
Copy link
Collaborator Author

ludviggunne commented Jun 3, 2025

The *.ts files should have been omitted from this.

I could revert those files?

...still a dozen other issues.

Are you tlaking about issues in this PR?

@firewave
Copy link
Collaborator

firewave commented Jun 3, 2025

The *.ts files should have been omitted from this.

I could revert those files?

No need.

...still a dozen other issues.

Are you tlaking about issues in this PR?

No, I was referring to #7079.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants