fixed #12841 - added frontend for shared CLI and GUI code
#7579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmar
reviewed
Jun 12, 2025
Owner
danmar
left a comment
danmar
left a comment
There was a problem hiding this comment.
I don't know what code you want to move to "frontend".
|
|
||
| #include "frontend.h" | ||
|
|
||
| namespace frontend |
Owner
There was a problem hiding this comment.
if there is no code in the frontend I don't understand why we add this.
Collaborator
Author
There was a problem hiding this comment.
This just adds in the framework. The code will be added in the follow-up #7570.
Collaborator
Author
Code that currently exists in |
danmar
approved these changes
Jun 13, 2025
Collaborator
Author
Having some shared logic will also allow us to unit tests more code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updated the
*filtersfiles