fixed #13990/#13991 - reworked platform lookup #7639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
Jul 1, 2025
firewave
commented
Jul 1, 2025
firewave
commented
Jul 4, 2025
firewave
changed the title
Collaborator
Author
|
The platform loading code is now essentially what will be the shared code for all loading. There is still a few things to resolve and I need to check it against the code in the UI before moving to that. |
firewave
commented
Jul 6, 2025
Comment on lines
+407
to
+408
| # TODO: test with invalid file in project path | ||
| # TODO: test with non-file in project path |
Collaborator
Author
There was a problem hiding this comment.
Will be addressed in a follow-up to not cramp more stuff into this.
Collaborator
Author
|
Anything still to do here? Otherwise I will rebase (just to be safe) and merge so I can proceed. |
Collaborator
Author
|
Any feedback? |
danmar
reviewed
Oct 25, 2025
danmar
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.