Fix #14064 Files are reanalyzed with --cppcheck-build-dir and inline suppressions (regression)

[chrchr-github]

No description provided.

[firewave]

As the suppression could contain a pattern we need to use the matching logic of the suppressions.

[chrchr-github]

Not sure I follow. There is only one suppression at a time, and we only care about inline suppressions.

[firewave]

Way to test the non-inline suppression case:

• create two input files
• analyze with builddir
• provide --suppress CLI option which only matches one of the files
• re-analyze
• make sure only the matching file has a different hash

[firewave]

It is possible that unmatchedSuppression warnings could somehow be leveraged to test this - but since those are still partially broken that is not really an option.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[firewave]

LGTM but tests requiring sleep always give me pause. But not writing at all and not modifying are actually different cases (not necessary to address here). I will try to write some tests at a later date.

Although I/we should rather work on #7079 as a priority and IMO no more builddir changes should be landed before that is in.

[chrchr-github]

LGTM but tests requiring sleep always give me pause. But not writing at all and not modifying are actually different cases (not necessary to address here). I will try to write some tests at a later date.

sleep() is not strictly required. But depending on file time granularity and execution speed, reanalysis could happen in "zero time" and would not be caught without it.
On a related note, the loop with 10 repetitions caused the test to fail ~90% of the time before the fix.

[chrchr-github]

We might want to backport this to 2.18 as well.

[firewave]

We might want to backport this to 2.18 as well.

Definitely.

[firewave]

We might want to backport this to 2.18 as well.

See #7756.