Fix #13645 (fail to load platform when executing Cppcheck in PATH) #7977
Conversation
|
The ticket is assigned to me and I have not acted on this because the wanted behavior is not yet determined (see #7613). Also this needs to be tested across all the external files we are loading. |
Ah sorry, that discussion was about CWD and this is related to PATH. |
|
|
I feel I have taken care of your requests and that this fix problems to execute cppcheck. So I merge this. |
| @pytest.mark.parametrize("type,file", [("addon", "misra.py"), ("config", "cppcheck.cfg"), ("library", "gnu.cfg"), ("platform", "avr8.xml")]) | ||
| def test_lookup_path(tmpdir, type, file): |
There was a problem hiding this comment.
I asked you not to do this. And the readability of this test is beyond horrible. It is impossible to understand what this is testing. And there are no failing tests at all. The expected output is supposed to be identical for all types and that is not reflected at it. This is not usable for test-driven development of my future changes. I will post a PR as soon as I cauught up again.
There was a problem hiding this comment.
ok sure we can try to refactor it. I just fear that splitting it up is not ideal neither, this way we know PATH is tested for all variants. But yes I agree my test code is clumpsy..
Sorry for not replying but I was occupied otherwise for a few days and then I got sick... |
2 participants
No description provided.