fix: leak + double header tokenizing in simplecpp::load #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was catched using the leak sanitizer that is part of the address sanitizer. On the line `ret[header2] = tokens;`, sometimes there is already a key `header2` in the `ret` map, causing both overriding(leak) and wasteful header tokenizing (two times at least).
Contributor
Author
|
Closing as unneeded, since the memory leak was found and avoided correctly in #429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was catched using the leak sanitizer that is part of the address sanitizer.
On the line
ret[header2] = tokens;, sometimes there is already a keyheader2in theretmap, causing both overriding(leak) and wasteful header tokenizing (two times at least).