Improve test runner script with refactoring and prerequisite checks #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
improve-test-runner
branch
from
86f3774 to
3505c8f
Compare
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
jcfr
force-pushed
the
improve-test-runner
branch
3 times, most recently
from
dc55734 to
129b151
Compare
firewave
reviewed
Aug 26, 2025
firewave
reviewed
Aug 26, 2025
jcfr
force-pushed
the
improve-test-runner
branch
2 times, most recently
from
c6a0970 to
51a3803
Compare
Contributor
Author
firewave
reviewed
Aug 27, 2025
jcfr
force-pushed
the
improve-test-runner
branch
from
51a3803 to
d88f23f
Compare
Contributor
Author
|
For additional context, the initial goal of this pull request was to allow me to understand the missing prerequisites. The proposed improvements fulfill this. This is now ready for integration 🙏 |
jcfr
force-pushed
the
improve-test-runner
branch
from
2f1962a to
8203180
Compare
|
@jcfr Thank you for making this MUCH easier to understand. |
Collaborator
Yeah - it is (was) a bit of a mess. I just started digging into it in the past few days myself. |
danmar
reviewed
Aug 29, 2025
jcfr
force-pushed
the
improve-test-runner
branch
from
8203180 to
2bc5572
Compare
This change refactors the test runner script by adding a `run()` function for executing compiler commands, capturing their output, and returning the results.
This change updates the test runner script to check for the presence of required compilers (clang, gcc) before running tests.
Suggested-by: Oliver Stöneberg <firewave@users.noreply.github.com>
…s handling Suggested-by: Oliver Stöneberg <firewave@users.noreply.github.com>
Suggested-by: Oliver Stöneberg <firewave@users.noreply.github.com>
`from __future__ import annotations` is useful in importable packages to enable postponed evaluation of annotations. However, in a standalone script like `run-tests.py`, it adds no value.
jcfr
force-pushed
the
improve-test-runner
branch
from
2bc5572 to
89e6b31
Compare
firewave
approved these changes
Aug 29, 2025
Collaborator
firewave
left a comment
firewave
left a comment
There was a problem hiding this comment.
LGTM. The stuff I wanted to check will need to be redone anyways, so no need to further look into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the test runner script with two main improvements:
run()function that centralizes the logic for executing compiler commands, capturing their output, and returning results.clang,gcc) are present before running tests.