Skip to content

Fix heap-buffer-overflow read in TARGA RLE loader #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JorgeBarredo14 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix heap-buffer-overflow read in TARGA RLE loader #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Source/FreeImage/PluginTARGA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,13 @@ loadRLE(FIBITMAP*& dib, int width, int height, FreeImageIO* io, fi_handle handle
if (remaining_size < height) {
throw FI_MSG_ERROR_CORRUPTED;
}
const long sz = (remaining_size / height);
long sz = (remaining_size / height);

// Ensure the cache is at least one pixel wide to prevent
// out-of-bounds reads when getBytes(file_pixel_size) is called.
if (sz < file_pixel_size) {
sz = file_pixel_size;
}

// ...and allocate cache of this size (yields good results)
IOCache cache(io, handle, sz);
Expand Down