Skip to content

Fix done for nexthop as IPv4 mapped IPv6 address. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hariosniral wants to merge 1 commit into from
Closed

Fix done for nexthop as IPv4 mapped IPv6 address. #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/netinet6/route_v6.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,6 +2912,10 @@ int handle_route6(vrfid_t vrf_id, uint16_t type, const struct rtmsg *rtm,
if (!(nl_flags & NL_FLAG_ANY_ADDR))
flags |= RTF_GATEWAY;

if (IN6_IS_ADDR_V4MAPPED(&gw)) {
Copy link
Copy Markdown

@ghost ghost Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the check only here won't the case of having an ECMP route, such as in the case of having an eiBGP 6PE/6VPE route. In addition, it possibly is confusing to the reader to look gw here, when it may or may not be used. Thus I would suggest pushing this check inside mpath conditional else block just below, and adding a similar check to the appropriate place in the logic called from ecmp6_create.

Copy link
Copy Markdown

@KaushikNiral KaushikNiral Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Robert,

Thanks for your review.
We understood your corrections suggested.
In ecmp6_create() we see nexthop6_fill_mpls() is already having the similar check, so we are adding the check in nexthop6_fill().

Thanks,

flags |= RTF_MAPPED_IPV6;
}

if (mpath) {
next = ecmp6_create(mpath, &size, &missing_ifp);
if (missing_ifp)
Expand Down