Skip to content

DPI: Avoid concurrent access of ndpi_flow_struct by multiple lcores #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shubham-cdot wants to merge 1 commit into from
Closed

DPI: Avoid concurrent access of ndpi_flow_struct by multiple lcores #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/npf/dpi/ndpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/*
* Copyright (c) 2020 AT&T Intellectual Property. All rights reserved.
* Copyright (c) 2021 Centre for Development of Telematics. All rights reserved.
*
* SPDX-License-Identifier: LGPL-2.1-only
*/
Expand Down Expand Up @@ -54,6 +55,7 @@ struct ndpi_flow {
uint32_t type;
struct ndpi_id_struct *src_id;
struct ndpi_id_struct *dest_id;
rte_spinlock_t fl_lock;
struct rcu_head n_rcu_head;
};

Expand Down Expand Up @@ -150,13 +152,15 @@ dpi_ndpi_process_pkt(struct dpi_engine_flow *engine_flow,
if (unlikely(!flow->key))
return false;

rte_spinlock_lock(&flow->fl_lock);
if (!dpi_ndpi_process(detection_modules[dp_lcore_id()],
mbuf, flow)) {
flow->protocol = DPI_APP_ERROR;
flow->offloaded = true;
flow->error = true;
}

rte_spinlock_unlock(&flow->fl_lock);
return true;
}

Expand Down Expand Up @@ -302,6 +306,7 @@ dpi_ndpi_session_first_packet(struct npf_session *se __unused,
flow->type = DPI_APP_TYPE_NONE;
flow->error = false;
flow->offloaded = false;
rte_spinlock_init(&flow->fl_lock);

flow->key = ndpi_flow_malloc(SIZEOF_FLOW_STRUCT);
if (!flow->key)
Expand Down