Feat/ach pull #11
Open
Feat/ach pull #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmmyers
previously approved these changes
Jan 30, 2023
jonmmyers
previously approved these changes
Feb 9, 2023
asmsh
suggested changes
Feb 10, 2023
src/Dapi/DapiApp.cs
Outdated
Comment on lines
410
to
436
| /// <summary> | ||
| /// createACHPull talks to the CreateACHPull endpoint of Dapi, with this DapiApp's appSecret. | ||
| /// </summary> | ||
| /// | ||
| /// <param name="transfer"> | ||
| /// the details of the transfer that should be initiate. | ||
| /// </param> | ||
| /// <param name="accessToken"> | ||
| /// retrieved from the ExchangeToken process. | ||
| /// </param> | ||
| /// <param name="userSecret"> | ||
| /// retrieved from the user login. | ||
| /// </param> | ||
| public CreateACHPullResponse createACHPull(ACH.ACHPull transfer, string accessToken, string userSecret) { | ||
| return this.c.createACHPull(transfer, accessToken, userSecret, "", null); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// createACHPull talks to the CreateACHPull endpoint of Dapi, with this DapiApp's appSecret. | ||
| /// </summary> | ||
| /// <param name="userSecret"> | ||
| /// retrieved from the user login. | ||
| /// </param> | ||
| public GetACHPullResponse getACHPull(string accessToken, string userSecret) { | ||
| return this.c.getACHPull(accessToken, userSecret, "", null); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Move them to be after the getAccountsMetadata method.
Contributor
There was a problem hiding this comment.
Both methods should have 2 versions, one that has the operationID and userInputs parameters, and one that doesn't.
Contributor
There was a problem hiding this comment.
Also, in the case of getACHPull, the operationID has to be always passed, as it's a required field for the endpoint.
src/Dapi/Products/ACH.cs
Outdated
| return respBody ?? new GetACHPullResponse("UNEXPECTED_RESPONSE", "Unexpected response body"); | ||
| } | ||
|
|
||
| public class ACHPull { |
src/Dapi/Products/ACH.cs
Outdated
Comment on lines
82
to
84
| this.senderID = transfer.senderID; | ||
| this.amount = transfer.amount; | ||
| this.description = transfer.description; |
Contributor
There was a problem hiding this comment.
This will not work. These fields should be inside the transfer object field, not directly in the root.
| /// This is a private constructor to this lib. | ||
| /// </summary> | ||
| [JsonConstructor] | ||
| internal CreateACHPullResponse(APIStatus status, bool success, string operationID) : |
Contributor
There was a problem hiding this comment.
This constructor is missing the userInputs, type and msg fields.
src/Dapi/Types/ACHGetTransfer.cs
Outdated
| @@ -0,0 +1,13 @@ | |||
| namespace Dapi.Types { | |||
| public class ACHGetTransfer { | |||
Contributor
There was a problem hiding this comment.
Rename it to ACHPullTransferInfo.
| /// This is a private constructor to this lib. | ||
| /// </summary> | ||
| [JsonConstructor] | ||
| internal GetACHPullResponse(ACHGetTransfer transfer, string reference, APIStatus status, bool success, string operationID) : |
Contributor
There was a problem hiding this comment.
This constructor is missing the userInputs, type and msg fields.
added 6 commits
February 10, 2023 16:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.