Migrate docker installation method #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: 93731a1 This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
pablomendezroyo
force-pushed
the
pablo/docker-apt
branch
from
edb00ab to
cb09dd9
Compare
pablomendezroyo
commented
Jul 26, 2023
Contributor
Author
|
@3alpha @Marketen @dappnodedev please add your review, this is a critical implementation 🙏 |
dsimog01
suggested changes
Sep 18, 2023
| log "Failed to source dappnode profile." | ||
| exit 1 | ||
| fi | ||
| # TODO: consider removing old docker-compose binary |
Contributor
There was a problem hiding this comment.
You are right here. Do we know which of them will be used if both exist ( docker-compose alias and docker-compose old binary)?
Contributor
Author
|
Depends on dappnode/DNP_DAPPMANAGER#1592 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate docker installation method from package to repository