Skip to content

Add truncate param to indexesToString #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablomendezroyo merged 2 commits into from
Aug 1, 2025
Merged

Add truncate param to indexesToString #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c75ca6b
add truncate arg
pablomendezroyo Aug 1, 2025
30ef2bb
fix lint
pablomendezroyo Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions internal/adapters/notifier/notifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ func (n *Notifier) SendValidatorLivenessNot(validators []domain.ValidatorIndex,
status = Resolved
isBanner = false
} else {
title = fmt.Sprintf("Validator(s) Offline: %s", indexesToString(validators))
body = fmt.Sprintf("❌ Validator(s) %s are not attesting on %s.", indexesToString(validators), n.Network)
title = fmt.Sprintf("Validator(s) Offline: %s", indexesToString(validators, true))
body = fmt.Sprintf("❌ Validator(s) %s are not attesting on %s.", indexesToString(validators, true), n.Network)
priority = High
status = Triggered
isBanner = true
Expand All @@ -149,8 +149,8 @@ func (n *Notifier) SendValidatorLivenessNot(validators []domain.ValidatorIndex,

// SendValidatorsSlashedNot sends a notification when one or more validators are slashed.
func (n *Notifier) SendValidatorsSlashedNot(validators []domain.ValidatorIndex) error {
title := fmt.Sprintf("Validator(s) Slashed: %s", indexesToString(validators))
body := fmt.Sprintf("🚨 Validator(s) %s have been slashed on %s! Immediate attention required.", indexesToString(validators), n.Network)
title := fmt.Sprintf("Validator(s) Slashed: %s", indexesToString(validators, true))
body := fmt.Sprintf("🚨 Validator(s) %s have been slashed on %s! Immediate attention required.", indexesToString(validators, true), n.Network)
priority := Critical
status := Triggered
isBanner := true
Expand Down Expand Up @@ -190,12 +190,12 @@ func (n *Notifier) SendBlockProposalNot(validators []domain.ValidatorIndex, epoc
}
}
if proposed {
title = fmt.Sprintf("Block Proposed: %s", indexesToString(validators))
body = fmt.Sprintf("✅ Validator(s) %s proposed a block at epoch %d on %s.", indexesToString(validators), epoch, n.Network)
title = fmt.Sprintf("Block Proposed: %s", indexesToString(validators, true))
body = fmt.Sprintf("✅ Validator(s) %s proposed a block at epoch %d on %s.", indexesToString(validators, true), epoch, n.Network)
priority = Info
} else {
title = fmt.Sprintf("Block Missed: %s", indexesToString(validators))
body = fmt.Sprintf("❌ Validator(s) %s missed a block proposal at epoch %d on %s.", indexesToString(validators), epoch, n.Network)
title = fmt.Sprintf("Block Missed: %s", indexesToString(validators, true))
body = fmt.Sprintf("❌ Validator(s) %s missed a block proposal at epoch %d on %s.", indexesToString(validators, true), epoch, n.Network)
priority = High
}
payload := NotificationPayload{
Expand All @@ -213,11 +213,12 @@ func (n *Notifier) SendBlockProposalNot(validators []domain.ValidatorIndex, epoc
}

// Helper to join validator indexes as comma-separated string
func indexesToString(indexes []domain.ValidatorIndex) string {
// If truncate is true, only the first 10 are shown, then '...'.
func indexesToString(indexes []domain.ValidatorIndex, truncate bool) string {
var s []string
max := 10
for i, idx := range indexes {
if i == max {
if truncate && i == max {
s = append(s, "...")
break
}
Expand All @@ -231,6 +232,6 @@ func (n *Notifier) buildBeaconchaURL(indexes []domain.ValidatorIndex) string {
if len(indexes) == 0 || n.BeaconchaUrl == "" {
return ""
}
// Always use dashboard?validators=... format for all cases
return fmt.Sprintf("%s/dashboard?validators=%s", n.BeaconchaUrl, indexesToString(indexes))
// Do not truncate for URLs
return fmt.Sprintf("%s/dashboard?validators=%s", n.BeaconchaUrl, indexesToString(indexes, false))
}