Skip to content

Revert back to built-in Docsy template that includes GA script#4564

Merged
hhunter-ms merged 1 commit intodapr:v1.15from
marcduiker:v1.15
Mar 3, 2025
Merged

Revert back to built-in Docsy template that includes GA script#4564
hhunter-ms merged 1 commit intodapr:v1.15from
marcduiker:v1.15

Conversation

@marcduiker
Copy link
Copy Markdown
Contributor

@marcduiker marcduiker commented Mar 3, 2025

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

In this commit I added an override to the head partial to exclude a GA script because I thought this was injected during deployment (as is happening with the dapr.io website). This appeared to be incorrect, so this PR deletes the override to use the built-on Docsy head partial again.

In the long term, I suggest the GA script to be included in the same way across website and docs to avoid confusion. Right now, just get GA working again for docs by merging this PR.

Issue reference

Signed-off-by: Marc Duiker <marcduiker@users.noreply.github.com>
@marcduiker marcduiker requested review from a team as code owners March 3, 2025 10:00
@hhunter-ms hhunter-ms merged commit 287cfd7 into dapr:v1.15 Mar 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants