Promote job and subscribeToEvents out of preview#1597
Closed
salaboy wants to merge 2 commits intodapr:masterfrom
Closed
Promote job and subscribeToEvents out of preview#1597salaboy wants to merge 2 commits intodapr:masterfrom
salaboy wants to merge 2 commits intodapr:masterfrom
Conversation
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
force-pushed
the
api-promotion
branch
from
78e06d2 to
7bb9bd3
Compare
3 tasks
cicoyle
requested changes
Dec 3, 2025
Contributor
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
I agree with the intent of this PR.
Can you check CI - it appears to be very red.
| public static void main(String[] args) throws Exception { | ||
| String topicName = getTopicName(args); | ||
| try (var client = new DaprClientBuilder().buildPreviewClient()) { | ||
| try (var client = new DaprClientBuilder().build()) { |
Contributor
There was a problem hiding this comment.
Collaborator
Author
|
open a new PR only with Jobs promotion |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
============================================
+ Coverage 76.91% 78.50% +1.59%
- Complexity 1592 1934 +342
============================================
Files 145 216 +71
Lines 4843 5872 +1029
Branches 562 659 +97
============================================
+ Hits 3725 4610 +885
- Misses 821 924 +103
- Partials 297 338 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Promoting Jobs and SucribeToEvents out of the preview client
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1594
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: