Introduce closeNow() to allow a "now" shutdown#1632
Open
mcruzdev wants to merge 4 commits intodapr:masterfrom
Open
Introduce closeNow() to allow a "now" shutdown#1632mcruzdev wants to merge 4 commits intodapr:masterfrom
mcruzdev wants to merge 4 commits intodapr:masterfrom
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
mcruzdev
force-pushed
the
durable-task-close-now
branch
from
e1c4d90 to
6094775
Compare
mcruzdev
changed the title
siri-varma
reviewed
Jan 30, 2026
| /** | ||
| * Immediately shuts down all resources associated with this instance. | ||
| */ | ||
| public void closeNow() { |
Contributor
There was a problem hiding this comment.
@mcruzdev When would one use close vs closeNow ?
Contributor
Author
There was a problem hiding this comment.
Hi @siri-varma, when we have a I live reload feature or when I am running tests.
Contributor
There was a problem hiding this comment.
Should we be handling the interrupted exception in this method ?
Apart from that everything looks good
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1632 +/- ##
============================================
- Coverage 78.99% 78.95% -0.04%
Complexity 2096 2096
============================================
Files 228 228
Lines 6322 6325 +3
Branches 693 693
============================================
Hits 4994 4994
- Misses 976 979 +3
Partials 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new method in
WorkflowRuntimeclass, allowing a shutdown "now" approach.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1631
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: