Conversation
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
|
I cannot add reviewers due to permission issues on this repo. Tagging @johnewart , @cgillum, @artursouza , @cicoyle for review. |
cgillum
left a comment
There was a problem hiding this comment.
Overall looks good to me! Just a few small things I noticed.
examples/src/main/java/io/dapr/examples/workflows/chain/ToUpperCaseActivity.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/dapr/examples/workflows/continueasnew/DemoContinueAsNewWorker.java
Outdated
Show resolved
Hide resolved
examples/src/main/java/io/dapr/examples/workflows/subworkflow/ReverseActivity.java
Outdated
Show resolved
Hide resolved
sdk-workflows/src/main/java/io/dapr/workflows/DaprWorkflowContextImpl.java
Show resolved
Hide resolved
b1c6aaa to
65c83ad
Compare
mukundansundar
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
A few comments to add auto validation mechanical-markdown script to README and removal of gRPC update and have it as a separate one if possible.
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
|
This is great - thanks for enhancing the workflow example 🎉 It looks like you may need to tweak the port, since the build is failing due to the port not being available, but looks good 👍🏻 |
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: kaibocai <kaibocai@microsoft.com>
256849f to
3eef63e
Compare
Signed-off-by: kaibocai <kaibocai@microsoft.com>
|
Hi @artursouza , @cicoyle and @mukundansundar . I need some help on the Auto Validate Examples, I could not figure out the right configuration. However, everything works as expected on my local. Thanks. |
Signed-off-by: kaibocai <kaibocai@microsoft.com>
Signed-off-by: Kaibo Cai (from Dev Box) <kaibocai@microsoft.com>
| Once you start the workflow and client using the following commands: | ||
| ```sh | ||
| dapr run --app-id demoworkflowworker --resources-path ./components/workflows --dapr-grpc-port 50001 -- java -jar target/dapr-java-sdk-examples-exec.jar io.dapr.examples.workflows.DemoWorkflowWorker | ||
| dapr run --app-id demoworkflowworker --resources-path ./components/workflows -- java -jar target/dapr-java-sdk-examples-exec.jar io.dapr.examples.workflows.continueasnew.DemoContinueAsNewWorker |
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Signed-off-by: kaibocai <89094811+kaibocai@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #949 +/- ##
=========================================
Coverage 76.54% 76.54%
Complexity 1467 1467
=========================================
Files 137 137
Lines 4472 4472
Branches 527 527
=========================================
Hits 3423 3423
Misses 763 763
Partials 286 286 ☔ View full report in Codecov by Sentry. |
Description
This PR
Chaining Pattern
Fan-out/Fan-in Pattern
Continue As New Pattern
External Event Pattern
Sub-workflow Pattern
This PR is based on #947, and should be merged after it.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #944, #911
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: