Skip to content

Conversation

@elena-kolevska
Copy link
Contributor

@elena-kolevska elena-kolevska commented Jan 28, 2025

Description

Catches error from daprd in the sdk when workflow instance not found, so that users don't have to do try/catch in the app.
Instead, when daprd can't find the workflow instance get_workflow_state will return None, as specified in the doc comment.

Also adds a small demo workflows examples fix.

Issue reference

#745

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests

Release Note

RELEASE NOTE: FIX Return None instead of throwing an error when a workflow instance is not found

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska requested review from a team as code owners January 28, 2025 12:37
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.15@7d05d6f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.15     #771   +/-   ##
===============================================
  Coverage                ?   86.29%           
===============================================
  Files                   ?       89           
  Lines                   ?     5029           
  Branches                ?        0           
===============================================
  Hits                    ?     4340           
  Misses                  ?      689           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought I do see the sense of wrapping the not found to a None return and raising anything else. Seeing if it's there or not will be the most common check I imagine.

I have a question on the detection of the not found.

Signed-off-by: Elena Kolevska <elena@kolevska.com>
@elena-kolevska elena-kolevska merged commit 488189e into dapr:release-1.15 Jan 28, 2025
15 checks passed
@elena-kolevska elena-kolevska deleted the release-1.15 branch January 28, 2025 22:24
@elena-kolevska elena-kolevska modified the milestones: v1.15, workflow-0.6.0 Jan 28, 2025
elena-kolevska added a commit to elena-kolevska/python-sdk that referenced this pull request Mar 6, 2025
* Catch error in sdk when workflow instance not found

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* fixes demo workflow example test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Only return None for the correct error

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Extends test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska added a commit to elena-kolevska/python-sdk that referenced this pull request Mar 6, 2025
* Catch error in sdk when workflow instance not found

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* fixes demo workflow example test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Only return None for the correct error

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Extends test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska added a commit to elena-kolevska/python-sdk that referenced this pull request Mar 6, 2025
* Catch error in sdk when workflow instance not found

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* fixes demo workflow example test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Only return None for the correct error

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Extends test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
elena-kolevska added a commit that referenced this pull request Mar 11, 2025
* Catch error in sdk when workflow instance not found (#771)

* Catch error in sdk when workflow instance not found

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* fixes demo workflow example test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Only return None for the correct error

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Extends test

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Fix get_worfklow_state docstring to match fetch_payloads default (#772)

Signed-off-by: Adam Stewart <adam.stewart73@gmail.com>
Co-authored-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Remove test sleep (#778)

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Restores sleeps in test, as it was decided not to invest making synchronous the APIs that are getting deleted next version (#781)

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates workflows docs to use the new workflows client (#780)

* Updates docs

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* More workflows docs

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Move workflows examples, based on review

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Small fixes

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Workflow fixes and improvements (#784)

* Converts demo_workflow example to DaprWorkflowClient and removes default timeout of 60seconds on `wait_for_workflow_start` and `wait_for_workflow_completion`

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Bumps durable task library.

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
# Conflicts:
#	ext/dapr-ext-workflow/setup.cfg

* Retry streaming subscription on status UNKNOWN as well (#783)

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds examples and docs for cloud events messages (#785)

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Conversation API support (#787)

* Conversation API support (sync)

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* async conversation api support

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Adds docs

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Ignore validation of x.com link that needs authentication

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Registers e2e test. Clean up.

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Apply suggestions from code review

Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>

* Linter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates protos and renames parameter

Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Improves error handling

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Signed-off-by: Elena Kolevska <elena@kolevska.com>

* Updates dev version to 1.15.0

Signed-off-by: Elena Kolevska <elena@kolevska.com>

---------

Signed-off-by: Elena Kolevska <elena@kolevska.com>
Signed-off-by: Adam Stewart <adam.stewart73@gmail.com>
Signed-off-by: Elena Kolevska <elena-kolevska@users.noreply.github.com>
Co-authored-by: Adam Stewart <ajstewart@users.noreply.github.com>
Co-authored-by: Marc Duiker <marcduiker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants