Add TravisCI + code coverage, exposes TypeError [ERR_INVALID_CALLBACK]: Callback must be a function #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I was playing around and it looks like one of the tests is
failing under some version of node. This pull-request illustrate the
issue
See following build:
https://travis-ci.com/GabLeRoux/node-zip/builds/73441118
https://travis-ci.com/GabLeRoux/node-zip/jobs/124102356
I see that this package seems to be used a lot in the Node community so testing
this in a CI may be helpful. 👍
This PR includes
daraosn/node-zipin readmedaraosn/node-zipin readmeNote: I also noticed that
nodezip-cli.jsis missing code coverage.