Skip to content

Conversation

@GabLeRoux
Copy link

@GabLeRoux GabLeRoux commented May 15, 2018

Hey there, I was playing around and it looks like one of the tests is
failing under some version of node. This pull-request illustrate the
issue

See following build:
https://travis-ci.com/GabLeRoux/node-zip/builds/73441118
https://travis-ci.com/GabLeRoux/node-zip/jobs/124102356

$ node --version
v10.1.0
Failures:
  1) nodezip when archiving a dummy file should be able to deflate file
   Message:
     TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
   Stacktrace:
     TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
    at makeCallback (fs.js:148:11)
    at Object.fs.unlink (fs.js:1016:14)
    at jasmine.Spec.<anonymous> (/home/travis/build/GabLeRoux/node-zip/test/nodezip_spec.js:38:15)

I see that this package seems to be used a lot in the Node community so testing
this in a CI may be helpful. 👍

This PR includes

  • travis badge pointing to daraosn/node-zip in readme
  • codecov badge pointing to daraosn/node-zip in readme
  • Running tests in many node versions

Note: I also noticed that nodezip-cli.js is missing code coverage.

@GabLeRoux GabLeRoux changed the title Add CI tests + coverage Add CI tests + code coverage, exposes TypeError [ERR_INVALID_CALLBACK]: Callback must be a function May 15, 2018
@GabLeRoux GabLeRoux changed the title Add CI tests + code coverage, exposes TypeError [ERR_INVALID_CALLBACK]: Callback must be a function Add TravisCI + code coverage, exposes TypeError [ERR_INVALID_CALLBACK]: Callback must be a function May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant