Skip to content

fix-simultaneous-attack #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ichub merged 5 commits into from
Apr 4, 2022
Merged

fix-simultaneous-attack #190

ichub merged 5 commits into from
Apr 4, 2022

Conversation

@davidryan59
Copy link
Contributor

@davidryan59 davidryan59 commented Jan 6, 2022

I have:

  • Fixed plugin so the slider value is actually feeding into the df.move (previously the slider displayed correctly, but the move was always 50% of energy)
  • Provided 2 user parameters at top of file for easy customisation of defaults
  • Slider value initialised correctly
  • Slider label refactored
  • Made plugin description slightly more specific

@Bulmenisaurus
Copy link
Contributor

Bulmenisaurus commented Jan 7, 2022

I tested it, worked for me! 👍

This is seriously cool, thanks!

Bulmenisaurus
Bulmenisaurus previously approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@Bulmenisaurus Bulmenisaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harryhare
Copy link

harryhare commented Mar 29, 2022

hi，this plugin doesn't work on current version（0.6.5）, can you update this plugin to fix this?

@davidryan59
Copy link
Contributor Author

davidryan59 commented Apr 1, 2022

In v0.6.5 I am getting error on line var pg = df.getProcgenUtils();

Investigating, will fix

@davidryan59
Merge pull request #1 from cristobal/fix-simultaneous-attack
1016311 
Fix simultaneous attack make it compatible with v0.6.5
@davidryan59
Copy link
Contributor Author

davidryan59 commented Apr 1, 2022

I have merged @cristobal's PR into this, and it works now.

Ready for merge please

@cristobal cristobal mentioned this pull request Apr 1, 2022
Open
ichub
ichub reviewed Apr 1, 2022
View reviewed changes
@davidryan59 @ichub
Update content/productivity/simultaneous-attack/index.md
242df64 
Co-authored-by: Ivan Chub <ichub@users.noreply.github.com>
@ichub ichub merged commit 22b4ddf into darkforest-eth:master Apr 4, 2022
@davidryan59 davidryan59 deleted the fix-simultaneous-attack branch April 5, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ichub ichub ichub approved these changes

+1 more reviewer

@Bulmenisaurus Bulmenisaurus Bulmenisaurus left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidryan59 @Bulmenisaurus @harryhare @ichub @cristobal