Conversation
…tests Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/c604d3e3-b208-475d-89b6-c3a6006a7ab9
Copilot
AI
changed the title
[WIP] Update proximal method to conditionally add scaled identity matrix
Semi-proximal method for daqp_prox: regularise only singular Hessian directions
Mar 21, 2026
…l vs full-proximal Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/ddc7816e-3ac0-4f99-b061-9ba43104f484
Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/ddc7816e-3ac0-4f99-b061-9ba43104f484
Copilot
AI
changed the title
Semi-proximal method for daqp_prox: regularise only singular Hessian directions
Semi-proximal dispatch via n_prox; default eps_prox > 0; benchmark
Mar 21, 2026
…detection Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/42b3e154-cc2a-4229-8961-2ab4f1d050c5
Copilot
AI
changed the title
Semi-proximal dispatch via n_prox; default eps_prox > 0; benchmark
Fix LP regression: restore 1e-10 stagnation threshold for LP cycle detection
Mar 21, 2026
Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/3ba45c29-373f-4d1c-815f-78981cd0cb12
Copilot
AI
changed the title
Fix LP regression: restore 1e-10 stagnation threshold for LP cycle detection
Fix LP benchmark regression: restore Mar 21, 2026
eps_prox=1 in Julia LP setup
…tale Julia eps_prox workaround Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/2dc5486d-98e9-43f5-837d-c2bdab2ea2cf
Copilot
AI
changed the title
Fix LP benchmark regression: restore
Fix LP iteration regression introduced by n_prox-based dispatch
Mar 21, 2026
eps_prox=1 in Julia LP setup…er, fix benchmark fairness Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/8f333298-da40-41eb-99dc-428a077df3d3
Copilot
AI
changed the title
Fix LP iteration regression introduced by n_prox-based dispatch
Fix LP benchmark regression vs v0.8.1
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LP iteration counts differed between the current branch and v0.8.1 when run through the CMake benchmark (
-DBENCHMARK=ON). The root cause was a combination of a broken benchmark comparison path and an off-by-one in the proximal stagnation loop.Changes
src/api.c— restoren_prox = nfor LPsThe previous session removed this, which routed LPs to
daqp_ldpdirectly and broke LP solving. Restored:setup_daqp_ldpmust setwork->n_prox = work->nfor LPs sodaqp_solveroutes them todaqp_prox.src/daqp_prox.c— fix cycle-counter increment (LP stagnation)Pre-increment (
++cycle_counter) caused stagnation to fire one outer step earlier than v0.8.1 (11 vs 12 consecutive non-improving steps). Changed to post-increment to match v0.8.1 exactly.interfaces/daqp-julia/src/api.jl— restoreeps_prox=1for LP setupRequired for pre-v0.9 C libraries that dispatch via
eps_prox != 0rather thann_prox. Without this, old libs route LPs todaqp_ldp.interfaces/daqp-julia/test/benchmark.jl— fair old-lib comparisonThe workspace struct grew by 16 bytes (
prox_mask+n_prox) between v0.8.1 and current, shifting thesettingspointer from offset 208 → 224. When the benchmark swaps in the v0.8.1.so, Julia'ssettings()reads from the wrong offset (getsNULL) and silently fails to seteps_prox=1— so the old lib takes thedaqp_ldppath (few iterations) while the current lib takesdaqp_prox(many iterations), making the comparison unfair.Fix:
benchmark_lpnow uses the old-stylequadprog(QPj; settings=...)API with an explicitDAQPSettingsstruct whereeps_prox=1. This passes settings directly todaqp_quadprogby pointer, bypassing the workspace struct entirely and working correctly with both old and new library ABIs.⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.