Symmetrize Hessian in-place during setup (0.5*(H+H'))#135
Merged
Conversation
Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/64ce043c-45a2-4415-af04-33c3502e4028
Copilot
AI
changed the title
[WIP] Add symmetrization of Hessian in DAQP setup
Symmetrize Hessian in-place during setup (0.5*(H+H'))
Mar 22, 2026
Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/2c2e641d-2aac-4845-9acd-8471eba8ac5a
Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/cc0f5907-2fed-436a-a621-7fbd2d290f86
…al H Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/1ae17631-1e7d-47aa-b9e4-d1d9583eb84d
Co-authored-by: darnstrom <55484604+darnstrom@users.noreply.github.com> Agent-Logs-Url: https://github.com/darnstrom/daqp/sessions/1ae17631-1e7d-47aa-b9e4-d1d9583eb84d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
daqp_update_Rinv!is_factoredscan upper-triangle of raw H directly (O(n²/2) reads, no writes)H[i*n+i]directly (no Rinv buffer needed)RinvD→Rinvrestore guard to the dense path (not at function entry), matching v0.8.2's cleaner pointer management1e-12magic literals withzero_tolfor consistency🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.