[cronet_http] Update deps and jni/jnigen to 0.14#1754
[cronet_http] Update deps and jni/jnigen to 0.14#1754titanous wants to merge 2 commits intodart-lang:masterfrom
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| cronet_http | Non-Breaking | 1.3.3 | 1.3.3 | 1.4.0 Got "1.3.3" expected >= "1.4.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
Changelog Entry ❗
| Package | Changed Files |
|---|---|
| package:cronet_http | pkgs/cronet_http/lib/src/cronet_client.dart pkgs/cronet_http/lib/src/jni/jni_bindings.dart pkgs/cronet_http/pubspec.yaml |
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check.
Coverage ⚠️
| File | Coverage |
|---|---|
| pkgs/cronet_http/lib/src/cronet_client.dart | 💔 Not covered |
| pkgs/cronet_http/lib/src/jni/jni_bindings.dart | 💔 Not covered |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbols |
|---|
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/http/example/main.dart |
|
Being in |
|
Thanks for opening this. Unfortunately I didn't see this before opening #1793, sorry. I think the way we're treating nullability in this PR can be improved though. All the Kotlin parameters don't need to be null – if we look at the documentation provided in the cronet source itself, most of them are non-nullable and can remain that way. I'll close this PR in favor of the other one. Edit: Oh, I see why you did the Kotlin conversions, because it's going to be a subclass of Basically an example of dart-lang/native#2421 that I opened just 2 days ago. |
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.